fix: update phone if autoconfirm is enabled #1431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
J0
approved these changes
Feb 15, 2024
kangmingtay
force-pushed
the
km/fix-autoconfirm-phone-update
branch
from
88cbda4
to
95ad48c
Compare
kangmingtay
force-pushed
the
km/fix-autoconfirm-phone-update
branch
from
95ad48c
to
c87a5bc
Compare
J0
pushed a commit
that referenced
this pull request
Feb 19, 2024
🤖 I have created a release *beep* *boop* --- ## [2.143.0](v2.142.0...v2.143.0) (2024-02-19) ### Features * calculate aal without transaction ([#1437](#1437)) ([8dae661](8dae661)) ### Bug Fixes * deprecate hooks ([#1421](#1421)) ([effef1b](effef1b)) * error should be an IsNotFoundError ([#1432](#1432)) ([7f40047](7f40047)) * populate password verification attempt hook ([#1436](#1436)) ([f974bdb](f974bdb)) * restrict mfa enrollment to aal2 if verified factors are present ([#1439](#1439)) ([7e10d45](7e10d45)) * update phone if autoconfirm is enabled ([#1431](#1431)) ([95db770](95db770)) * use email change email in identity ([#1429](#1429)) ([4d3b9b8](4d3b9b8)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
uxodb
pushed a commit
to uxodb/auth
that referenced
this pull request
Nov 13, 2024
## What kind of change does this PR introduce? * In supabase#1407, the update user endpoint was refactored to use `smsVerify` if `GOTRUE_SMS_AUTOCONFIRM` is enabled. However, `smsVerify` doesn't update the user's phone number to the new one. This PR aims to fix that.
uxodb
pushed a commit
to uxodb/auth
that referenced
this pull request
Nov 13, 2024
🤖 I have created a release *beep* *boop* --- ## [2.143.0](supabase/auth@v2.142.0...v2.143.0) (2024-02-19) ### Features * calculate aal without transaction ([supabase#1437](supabase#1437)) ([8dae661](supabase@8dae661)) ### Bug Fixes * deprecate hooks ([supabase#1421](supabase#1421)) ([effef1b](supabase@effef1b)) * error should be an IsNotFoundError ([supabase#1432](supabase#1432)) ([7f40047](supabase@7f40047)) * populate password verification attempt hook ([supabase#1436](supabase#1436)) ([f974bdb](supabase@f974bdb)) * restrict mfa enrollment to aal2 if verified factors are present ([supabase#1439](supabase#1439)) ([7e10d45](supabase@7e10d45)) * update phone if autoconfirm is enabled ([supabase#1431](supabase#1431)) ([95db770](supabase@95db770)) * use email change email in identity ([supabase#1429](supabase#1429)) ([4d3b9b8](supabase@4d3b9b8)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
LashaJini
pushed a commit
to LashaJini/auth
that referenced
this pull request
Nov 13, 2024
## What kind of change does this PR introduce? * In supabase#1407, the update user endpoint was refactored to use `smsVerify` if `GOTRUE_SMS_AUTOCONFIRM` is enabled. However, `smsVerify` doesn't update the user's phone number to the new one. This PR aims to fix that.
LashaJini
pushed a commit
to LashaJini/auth
that referenced
this pull request
Nov 13, 2024
🤖 I have created a release *beep* *boop* --- ## [2.143.0](supabase/auth@v2.142.0...v2.143.0) (2024-02-19) ### Features * calculate aal without transaction ([supabase#1437](supabase#1437)) ([8dae661](supabase@8dae661)) ### Bug Fixes * deprecate hooks ([supabase#1421](supabase#1421)) ([effef1b](supabase@effef1b)) * error should be an IsNotFoundError ([supabase#1432](supabase#1432)) ([7f40047](supabase@7f40047)) * populate password verification attempt hook ([supabase#1436](supabase#1436)) ([f974bdb](supabase@f974bdb)) * restrict mfa enrollment to aal2 if verified factors are present ([supabase#1439](supabase#1439)) ([7e10d45](supabase@7e10d45)) * update phone if autoconfirm is enabled ([supabase#1431](supabase#1431)) ([95db770](supabase@95db770)) * use email change email in identity ([supabase#1429](supabase#1429)) ([4d3b9b8](supabase@4d3b9b8)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
LashaJini
pushed a commit
to LashaJini/auth
that referenced
this pull request
Nov 15, 2024
## What kind of change does this PR introduce? * In supabase#1407, the update user endpoint was refactored to use `smsVerify` if `GOTRUE_SMS_AUTOCONFIRM` is enabled. However, `smsVerify` doesn't update the user's phone number to the new one. This PR aims to fix that.
LashaJini
pushed a commit
to LashaJini/auth
that referenced
this pull request
Nov 15, 2024
🤖 I have created a release *beep* *boop* --- ## [2.143.0](supabase/auth@v2.142.0...v2.143.0) (2024-02-19) ### Features * calculate aal without transaction ([supabase#1437](supabase#1437)) ([8dae661](supabase@8dae661)) ### Bug Fixes * deprecate hooks ([supabase#1421](supabase#1421)) ([effef1b](supabase@effef1b)) * error should be an IsNotFoundError ([supabase#1432](supabase#1432)) ([7f40047](supabase@7f40047)) * populate password verification attempt hook ([supabase#1436](supabase#1436)) ([f974bdb](supabase@f974bdb)) * restrict mfa enrollment to aal2 if verified factors are present ([supabase#1439](supabase#1439)) ([7e10d45](supabase@7e10d45)) * update phone if autoconfirm is enabled ([supabase#1431](supabase#1431)) ([95db770](supabase@95db770)) * use email change email in identity ([supabase#1429](supabase#1429)) ([4d3b9b8](supabase@4d3b9b8)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
smsVerifyifGOTRUE_SMS_AUTOCONFIRMis enabled. However,smsVerifydoesn't update the user's phone number to the new one. This PR aims to fix that.