fix: add small fixes to v0.4.0 #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## What kind of change does this PR introduce? Currently, create server client doesn't seem to set cookies when MFA Challenge is verified
## What kind of change does this PR introduce? As per title
## What kind of change does this PR introduce? Bug fix ## What is the current behavior? When resetting a user's password with an email template which has a URL defining the `type` value as `recovery`, and using the `verifyOtp` method to process the token_hash and type, the SSR server client's `onAuthStateChange` function does not recognize the `PASSWORD_RECOVERY` event that verifyOtp fires. This prevents the code [here](https://github.com/supabase/ssr/blob/main/src/createServerClient.ts#L199-L205) from running; resulting in the new session not being saved to cookies, and the user is not considered logged in. Fixes #21 ## What is the new behavior? User is logged in. ## Additional context Replaces PR #24 Co-authored-by: Jason Creviston <jason@malynium.com>
## What kind of change does this PR introduce? so that we can unblock v0.4.1. Referencing the Auth workflow: https://github.com/supabase/auth/blob/master/.github/workflows/test.yml
hf
approved these changes
Jul 5, 2024
hf
pushed a commit
that referenced
this pull request
Jul 5, 2024
🤖 I have created a release *beep* *boop* --- ## [0.4.1](v0.4.0...v0.4.1) (2024-07-05) ### Bug Fixes * add small fixes to v0.4.0 ([#34](#34)) ([3640ef9](3640ef9)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Update v0.4.0 with small fixes