HEAD /object/authenticated/<bucket>/not_found should use status code 404

[Xuanwo]

Bug report

• I confirm this is a bug with Supabase, not with my own application.
• I confirm I have searched the Docs, GitHub Discussions, and Discord.

Describe the bug

supabase storage will return 400 error code for HEAD request while object not found.

To Reproduce

https://github.com/supabase/storage-api/blob/1794d04ab0e7259d9058293e257f442015252ec3/src/storage/renderer/renderer.ts#L45-L52

Expected behavior

The status code should be 404 since HEAD request will not have a body and there is no way for client to know what happened.

Screenshots

None

System information

Not related

Additional context

apache/opendal#2200

[xyjixyjixyji]

Actually the metadata like the status code 404 should be returned in the header for most requests instead of in the body. Currently I found that supabase always returns 400 in the header and stores its actual status_code in the body.

I am curious about the reason under the hood :)

[fenos]

Returning 400 instead of 404 was a legacy decision to force the user to branch error handling with the response code.
It is arguably not semantically correct as you mentioned.

We are happy to rethink our error handling status code for the next version and return the correct status code

[Xuanwo]

We are happy to rethink our error handling status code for the next version and return the correct status code

Thanks! The most confusing thing here is HEAD can't return a body so users don't need what error happened.

[rmkerr]

Hey! Just want to jump in here and say this would be nice for us at talc. Making this change would improve the clarity of our opentelemetry logging, as we categorize some logs into errors based on status code.