Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: custom trace spans #547

Merged
merged 1 commit into from
Sep 16, 2024
Merged

fix: custom trace spans #547

merged 1 commit into from
Sep 16, 2024

Conversation

fenos
Copy link
Contributor

@fenos fenos commented Sep 12, 2024

What kind of change does this PR introduce?

Improvement

What is the new behavior?

  • Implemented custom spans around specific function calls to measure the latency
  • Implemented additional mode: logs from the already existing basic, full
    • in this mode the span will be appended to the request log and not set upstream

Copy link

github-actions bot commented Sep 12, 2024

Pull Request Test Coverage Report for Build 10849592226

Details

  • 425 of 709 (59.94%) changed or added relevant lines in 20 files are covered.
  • 5 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.06%) to 78.676%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/storage/events/webhook.ts 0 1 0.0%
src/http/plugins/apikey.ts 10 12 83.33%
src/http/plugins/xml.ts 30 32 93.75%
src/http/plugins/log-request.ts 93 97 95.88%
src/http/plugins/tenant-id.ts 36 41 87.8%
src/http/plugins/jwt.ts 24 32 75.0%
src/http/plugins/tenant-feature.ts 9 17 52.94%
src/http/plugins/signature-v4.ts 43 66 65.15%
src/internal/monitoring/otel-processor.ts 11 37 29.73%
src/http/plugins/tracing.ts 14 109 12.84%
Files with Coverage Reduction New Missed Lines %
src/http/plugins/tracing.ts 2 23.7%
src/http/plugins/db.ts 3 53.74%
Totals Coverage Status
Change from base Build 10789667837: -0.06%
Covered Lines: 13483
Relevant Lines: 16992

💛 - Coveralls

@fenos fenos force-pushed the traces/custom-spans branch 2 times, most recently from 992c7ff to cb7cf3d Compare September 13, 2024 13:00
@fenos fenos merged commit 53cbaa7 into master Sep 16, 2024
1 check passed
@fenos fenos deleted the traces/custom-spans branch September 16, 2024 10:01
Copy link

🎉 This PR is included in version 1.11.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants