fix: improve request cancellation to keep the s3Client queue low #548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fenos
force-pushed
the
perf/improve-handling-of-request-cancellation
branch
3 times, most recently
from
032f5c5
to
b4c5062
Compare
Pull Request Test Coverage Report for Build 10917763267Details
💛 - Coveralls |
fenos
force-pushed
the
perf/improve-handling-of-request-cancellation
branch
from
b4c5062
to
a56ac29
Compare
inian
approved these changes
Sep 18, 2024
fenos
force-pushed
the
perf/improve-handling-of-request-cancellation
branch
from
a56ac29
to
5f9e0f8
Compare
|
🎉 This PR is included in version 1.11.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Perf improvement
What is the new behavior?
When we detect a client disconnect, we cancel the underline AWS S3 getObject request via abort signals