Skip to content

Commit 510c89e

Browse files
authored
Merge pull request #694 from superannotateai/FRIDAY-2919
Item interface
2 parents 35b0846 + 707d9e3 commit 510c89e

File tree

2 files changed

+15
-23
lines changed

2 files changed

+15
-23
lines changed

src/superannotate/lib/app/interface/sdk_interface.py

Lines changed: 13 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
import logging
55
import os
66
import sys
7+
import uuid
78
from pathlib import Path
89
from typing import Callable
910
from typing import Dict
@@ -879,12 +880,10 @@ def delete_items(self, project: str, items: Optional[List[str]] = None):
879880
:param items: to be deleted items' names. If None, all the items will be deleted
880881
:type items: list of str
881882
"""
882-
project, folder = self.controller.get_project_folder_by_path(project)
883-
response = self.controller.items.delete(
884-
project=project, folder=folder, item_names=items
885-
)
886-
if response.errors:
887-
raise AppException(response.errors)
883+
project_name, folder_name = extract_project_folder(project)
884+
project = self.controller.get_project(project_name)
885+
folder = project.get_folder(folder_name)
886+
folder.delete_items(item_names=items)
888887

889888
def assign_items(
890889
self, project: Union[NotEmptyStr, dict], items: List[str], user: str
@@ -904,13 +903,10 @@ def assign_items(
904903
:type user: str
905904
"""
906905

907-
project, folder = self.controller.get_project_folder_by_path(project)
908-
response = self.controller.projects.assign_items(
909-
project, folder, item_names=items, user=user
910-
)
911-
912-
if response.errors:
913-
raise AppException(response.errors)
906+
project_name, folder_name = extract_project_folder(project)
907+
project = self.controller.get_project(project_name)
908+
folder = project.get_folder(folder_name)
909+
folder.assign_items(user=user, item_names=items)
914910

915911
def unassign_items(
916912
self, project: Union[NotEmptyStr, dict], items: List[NotEmptyStr]
@@ -924,12 +920,10 @@ def unassign_items(
924920
:param items: list of items to unassign
925921
:type items: list of str
926922
"""
927-
project, folder = self.controller.get_project_folder_by_path(project)
928-
response = self.controller.projects.un_assign_items(
929-
project, folder, item_names=items
930-
)
931-
if response.errors:
932-
raise AppException(response.errors)
923+
project_name, folder_name = extract_project_folder(project)
924+
project = self.controller.get_project(project_name)
925+
folder = project.get_folder(folder_name)
926+
folder.assign_items(item_names=items)
933927

934928
def unassign_folder(self, project_name: NotEmptyStr, folder_name: NotEmptyStr):
935929
"""Removes assignment of given folder for all assignees.
@@ -2676,8 +2670,6 @@ def attach_items(
26762670
project = self.controller.get_project(project_name)
26772671
folder = project.get_folder(folder_name)
26782672
# todo validate Attachment
2679-
names = []
2680-
import uuid
26812673

26822674
seen_names = set()
26832675
unique_attachments = []

tests/integration/items/test_attach_items.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
import os
22
from pathlib import Path
3-
from unittest import TestCase
43

54
import pytest
65
from src.superannotate import AppException
@@ -88,10 +87,11 @@ def test_limitation(self):
8887
)
8988

9089

91-
class TestAttachItemsVectorArguments(TestCase):
90+
class TestAttachItemsVectorArguments(BaseTestCase):
9291
PROJECT_NAME = "TestAttachItemsVectorArguments"
9392

9493
def test_attach_items_invalid_payload(self):
94+
# todo update
9595
error_msg = [
9696
"attachments",
9797
"str type expected",

0 commit comments

Comments
 (0)