Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEV-CON] Streamline _deep_flat_encode & _deep_flat_decode #2547

Open
Tracked by #2475
blythed opened this issue Oct 22, 2024 · 1 comment
Open
Tracked by #2475

[DEV-CON] Streamline _deep_flat_encode & _deep_flat_decode #2547

blythed opened this issue Oct 22, 2024 · 1 comment
Labels
📉 technical debt Things that slow us down

Comments

@blythed
Copy link
Collaborator

blythed commented Oct 22, 2024

These functions involve too much logic; they should include fewer if clauses, and outsource
details of the serialization to the implementations.

@zeus2611
Copy link

zeus2611 commented Oct 23, 2024

Hi @blythed, I would like to take this up. As I can see in the superduper/superduper/base/document.py, both _deep_flat_encode & _deep_flat_decode functions are very complex and nested. So, we can create helper functions to handle the encoding of different object types and use those helper functions inside _deep_flat_encode & _deep_flat_decode functions based on the type of the object being encoded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📉 technical debt Things that slow us down
Projects
None yet
Development

No branches or pull requests

2 participants