Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DATATYPE] Migrate CFG.bytes_encoding to databackend #2628

Closed
Tracked by #2562
blythed opened this issue Nov 18, 2024 · 0 comments
Closed
Tracked by #2562

[DATATYPE] Migrate CFG.bytes_encoding to databackend #2628

blythed opened this issue Nov 18, 2024 · 0 comments
Assignees

Comments

@blythed
Copy link
Collaborator

blythed commented Nov 18, 2024

This prevents the need to reconfigure on a case-by-case basis.

class Databackend:
    bytes_encoding = 'bytes'


class IbisDatabackend:
    def __init__(self):
        if self.uri.startswith('snowflake'):
            self.bytes_encoding = 'str'
        ...

TODO: only do conversion between bytes and str if encodable == 'encodable'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

1 participant