Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] Make template serialization consistent with other component's serialization #2633

Open
blythed opened this issue Nov 20, 2024 · 0 comments
Assignees
Labels
blockage 📉 technical debt Things that slow us down

Comments

@blythed
Copy link
Collaborator

blythed commented Nov 20, 2024

Currently we have _builds nested x2 inside a template.encode() this is not elegant, and makes the editing of a template for a user difficult.

Instead we should have a single _builds field which combines everything from a Template in one field.

We should repurpose the Component.literals which stops the jobs being deployed on db.apply(template).

Outcome

This will make it easier to pass a response to the frontend, and deserialize without custom logic.

  1. /db/show_template will not be necessary
  2. /db/apply will be simplied
  3. Template.__call__ will no longer be necessary
@blythed blythed self-assigned this Nov 20, 2024
@blythed blythed added the 📉 technical debt Things that slow us down label Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blockage 📉 technical debt Things that slow us down
Projects
Status: To Do
Development

No branches or pull requests

1 participant