Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC]: vector search tutorial issues #2749

Open
wuhu opened this issue Jan 29, 2025 · 0 comments
Open

[DOC]: vector search tutorial issues #2749

wuhu opened this issue Jan 29, 2025 · 0 comments

Comments

@wuhu
Copy link

wuhu commented Jan 29, 2025

What's wrong?

(version: 0.5.1)

Here are some things I noticed reading https://docs.superduper.io/docs/tutorials/vector_search

  • Some of the links are broken.

  • It would be useful to mention that vector search requires an extra package (I got a ModuleNotFoundError and had to figure out what was going on)

  • db.apply(...) fails with

           137     def _pre_create(self, db: Datalayer, startup_cache: t.Dict = {}):
           138         assert isinstance(self.indexing_listener, Listener)
           139         assert hasattr(self.indexing_listener, 'output_table')
           140         assert hasattr(self.indexing_listener.output_table, 'schema')
           141         assert isinstance(self.indexing_listener, Listener)
           142         assert isinstance(self.indexing_listener.output_table, Table)
           143         try:
           144             assert isinstance(
           145                 self.indexing_listener.output_table.schema,
           146                 Schema,
           147             )
           148             next(
           149                 v
           150                 for v in self.indexing_listener.output_table.schema.fields.values()
           151                 if hasattr(v, 'shape') and v.shape is not None
           152             )
           153         except StopIteration:
      --> 154             raise Exception(
           155                 f'Couldn\'t get a vector shape for '
           156                 f'{self.indexing_listener.output_table.schema.huuid}'
           157             )
           158```
    
    
    

How could it be better?

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant