Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SUBGRAPH] Add a counter property for subscribers on an Index #776

Closed
vmichalik opened this issue May 5, 2022 · 3 comments
Closed

[SUBGRAPH] Add a counter property for subscribers on an Index #776

vmichalik opened this issue May 5, 2022 · 3 comments
Labels
Project: SUBGRAPH Superfluid protocol subgraph Size: S Type: Enhancement New feature or request

Comments

@vmichalik
Copy link
Collaborator

No description provided.

@vmichalik vmichalik added Project: SUBGRAPH Superfluid protocol subgraph Size: S Type: Enhancement New feature or request labels May 5, 2022
@hellwolf hellwolf added this to the subgraph@1.4 milestone May 9, 2022
@msoni89
Copy link
Contributor

msoni89 commented May 12, 2022

@kasparkallas

Please add more detail here.

Do you want me to increase and decrease the counter based on subscribe, or unsubscribe?

Is subscriber_count okay for the name?

@msoni89
Copy link
Contributor

msoni89 commented May 12, 2022

As per the discussion, we don't need to address it because it's already available as totalSubscriptionsWithUnits

@kasparkallas
Copy link
Contributor

kasparkallas commented May 12, 2022

Thank you, @msoni89

totalSubscriptionsWithUnits actually makes more sense than just totalSubscriptions. We should also display this number in the Console. I'll make a story for that and edit this comments.

Story here: superfluid-finance/superfluid-explorer#81

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Project: SUBGRAPH Superfluid protocol subgraph Size: S Type: Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants