Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggested improvements #122

Open
3 of 10 tasks
d10r opened this issue Sep 29, 2022 · 1 comment
Open
3 of 10 tasks

Suggested improvements #122

d10r opened this issue Sep 29, 2022 · 1 comment

Comments

@d10r
Copy link
Contributor

d10r commented Sep 29, 2022

  • protocol tab | contract addresses: add governance contract (currently discoverable by navigating to the Host -> Read Proxy -> getGovernance())
  • protocol tab | Governance parameters: add a list of "Trusted forwarders". Code for how to figure them out can be found [here[(https://github.com/superfluid-finance/protocol-monorepo/blob/dev/packages/ethereum-contracts/scripts/info-show-protocol.js#L138)
  • Network selector: add some visual and/or logical distinction between mainnets and testnets
  • navigation:
    • add the selected network as url param, don't change network when changing tab (e.g. protocol -> tokens)
    • remember selection when closing and re-opening tab
    • consider a stronger visual hint for what's currently selected, at the moment it's just a rather subtle green underscore.
  • navigation: use the same order of networks as in the dashboard
  • Avalanche C-chain: canonical explorer should be snowtrace (as long as we can't verify on avascan) - you may also get the canonical explorer from the metadata repo
  • SuperToken view: link SuperToken address to explorer (like already done for the underlying token)
@d10r
Copy link
Contributor Author

d10r commented Oct 10, 2022

working on #125, I noticed that the information architecture is a bit inconsistent.
The landing page shows "latest streams", with only mainnets selected by default.
Logically, this should probably be one of 4 console tabs, the others being "protocol", "tokens" and "subgraph".
After nesting "protocol" and "tokens" under into networks, the same should probably happen for "streams" and "subgraph", since those too show information about a specific network, and it would be good to have the chosen network apply regardless of which tab/functionality is selected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant