You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
When changing GCode Flavors and switching between printers, the wrong name of the GCode flavor is displayed. This is present in PrusaSlicer. Fix included
To Reproduce
Steps to reproduce the behavior:
Add to printers to SuperSlicr
Change the GCode Flavor to one ( Marlin -> Klipper ) without saving
Toggle to the second printer
Unsaved Changes Dialog is displayed showing the incorrect GCode Flavor names
>> Project File <<
Expected behavior
Correct and Selected GCode Flavors should be displayed
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):
The code already handles a case where all enum values arent in these vectors for infill. This same code path should be used for all enums displayed in the UnsavedChangesDialog since the performance hit to render this dialog would be minimal
The text was updated successfully, but these errors were encountered:
Describe the bug
When changing GCode Flavors and switching between printers, the wrong name of the GCode flavor is displayed. This is present in PrusaSlicer. Fix included
To Reproduce
Steps to reproduce the behavior:
>> Project File <<
Expected behavior
Correct and Selected GCode Flavors should be displayed
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):
Additional context
The issue is that the function in UnsaveChangesDialog.cpp
get_string_from_enum() makes the assumption that enums are added to the enum_labels and enum_values vectors in numerical order. This is not the case as "klipper" is added in the 6th position but has an enum value of 7 - https://github.com/supermerill/SuperSlicer/blob/master/src/libslic3r/PrintConfig.cpp#L1901
The code already handles a case where all enum values arent in these vectors for infill. This same code path should be used for all enums displayed in the UnsavedChangesDialog since the performance hit to render this dialog would be minimal
The text was updated successfully, but these errors were encountered: