Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

French language ? #273

Closed
le-belge opened this issue Jun 6, 2020 · 16 comments
Closed

French language ? #273

le-belge opened this issue Jun 6, 2020 · 16 comments
Labels
fix is live in the last release Please download /build the last release and try to reproduce. problem
Milestone

Comments

@le-belge
Copy link

le-belge commented Jun 6, 2020

Version

Version of SupserSlicer 2.2.51

OS : win 10 64 bit
Hi ,
great job on this software!
I love...
is it possible to have it in French?
Thanks
Mike

@supermerill
Copy link
Owner

i'm doing a pass on the french traduction file sometimes.
Currently, i think that i forgot to renamed all the traduction files, so there is nothing instead of half.
I'll do something for it for the next release.

@le-belge
Copy link
Author

le-belge commented Jun 6, 2020

excellent, that's great, thank you!

@neophrema
Copy link

I'm sorry, a little bit off-topic.
I found some spelling mistakes in Superslicer, should I file a report and where? Is it appreciated, since its just "cosmetics"?
E.g.: Perimeters&shell -> Quality -> extra perimeters on overhang - Tooltip.
check the writing please.

@supermerill
Copy link
Owner

supermerill commented Jun 9, 2020

ideally, you create a fork with the button int he top, then you modify the file (directly in github, search for it, if it's a setting, it's in printconfig.cpp.
then apply/commit, then push the "pull request" that should pop (in the root of your repo).
That will create a request for me to accept your changes.

Sorry for the misspelling, i'll try to do a triple-check now, but I'm not the most fluent english speaker/writer, so it's always nice to have people who can correct me/ improve my wording.

if you need it, you can modify the ui text by modifying your ui file, see resources/ui/readme.txt

@neophrema
Copy link

unfortunately I would have to look into a lot of (rewarding) details, since I do not use github, nor do I frequently compile programms myself (I'm not into programming). I simply don't have time for this right now, but maybe in a Month (a lot of duties right now). Still, I would like to help making something better, that's worth it (I appreciate your work). If you wouldn't mind I would come up with a list of spelling mistakes in the programm and list it? For this I think I should make a new issue;
Would that be helpful? Otherwise I can do like you requested but not now, but in a Month, since I have too much to do with University and Work.
I'm sorry. -
Which way to go?

@supermerill
Copy link
Owner

supermerill commented Jun 9, 2020

You don't need to install anything.

search the text you want to change in the search field.
Click on the file, then on the edit button (it's a pencil)
modify the text.
then click on propose change.

(but it's better if you modify all the bad string in the file before clicking on propose

see tuto here: https://help.github.com/en/github/managing-files-in-a-repository/editing-files-in-your-repository

If you give me a list of "replace that by this", that's exactly what i'm going to do anyway.
If you really can't use the search box and clicking on the edit button, then post the needed changes here, i will do the work.

@neophrema
Copy link

Thank you very much for your explanation. I will do so till the end of the Weekend. See you and thank you!

@neophrema
Copy link

neophrema commented Jun 14, 2020

I did a few changes, I will do more, have no time yet.
I hope this is helpful;

One last request: I think you should number the calibrations due to your advice to use them in ORDER.
Meaningly nameing them:

"1. Bed leveling"
"2. Flow calibration"
"3. Filament ..."

and so on.
ALSO: the first few lines in each calibration is regarding which you should have done first.
Therefore I think it should be standardized:

"Before this Calibration you should have done:

  • Bed Leveling
  • Flow calibration
  • Filament ... "

What do you think?

@supermerill
Copy link
Owner

It's a sensible improvement.
Maybe also I should add a How-to page with no calibration, but a quick explanation on how to use the menu, or what calibration to look after if there is a problem.

@neophrema
Copy link

Yes, I agree. It's a good idea.
I will continue looking for typos and co, there were some outside of the new calibration part; I wasn't able to find the sourcetext, I had to click on a lot of files to find that its in the HTML for some reason.
I hope I can be helpful, thank you very much for your work!

@supermerill
Copy link
Owner

supermerill commented Jun 15, 2020

oh, sorry, i didn't think of them.
It's done that way because it's easier to modify & format a big chunk of text with images in html.

settings text are in src/libslic3r/PrintConfig.cpp
some ui text (like the tab names) and some settings names are in resources/ui/??.ui
some other bits of settings that haven't made their way into ui files are in src/slic3r/GUI/Tab.cpp
some text hints are in src/slic3r/GUI/PresetHints.cpp
calibration texts are in resources/calibration/??/??.html
errors text are all over the place.

@le-belge
Copy link
Author

Hi, this is working hard as far as I can see!

@neophrema
Copy link

Im sorry, what are you referring to le-belge?

@supermerill
Copy link
Owner

I think he's just cheering us up.

@neophrema
Copy link

I just understood, yes i guess so- still, maybe he did misunderstood his personal issue since I was hijacking this thread. (I think you answered him before so I guess its ok.- I will look after the files you mentioned in the next few days; lot to do right now)
sincerely,
v.

@le-belge
Copy link
Author

no problem, I just wanted to say that it was good to see you work, I hope to have soon french to fully exploit this superb software!

@supermerill supermerill added this to the v53 milestone Jun 29, 2020
@supermerill supermerill added fix is live in the last release Please download /build the last release and try to reproduce. and removed working on labels Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix is live in the last release Please download /build the last release and try to reproduce. problem
Projects
None yet
Development

No branches or pull requests

3 participants