Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Update viper from v1.16.0 #2445

Closed
tsmethurst opened this issue Dec 11, 2023 · 0 comments
Closed

[chore] Update viper from v1.16.0 #2445

tsmethurst opened this issue Dec 11, 2023 · 0 comments
Assignees
Milestone

Comments

@tsmethurst
Copy link
Contributor

This is somehow causing build failures, which I think is due to it (somehow?) updating the experimental slices package we rely on in a few areas, i.e. "golang.org/x/exp/slices". As the build error is complaining that the slices sort function signature has changed. This can be fixed by updating the anonymous function signature we're using, and it would also be worth changing all of those files to instead import the standard library slices package "slices".

Though also to keep in mind, as @daenney pointed out in matrix, this version also seems to be causing issues for others too: spf13/viper#1706

Originally posted by @NyaaaWhatsUpDoc in #2441 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants