Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Padding issue #13

Closed
ghost opened this issue Jul 19, 2021 · 3 comments
Closed

Padding issue #13

ghost opened this issue Jul 19, 2021 · 3 comments

Comments

@ghost
Copy link

ghost commented Jul 19, 2021

Could you add some horizontal padding for the actual progress bar, when timeLabelLocation.sides is set? Or maybe exposing a new property for that?

Screenshot_20210719-205321_3

ProgressBar(
   ...
   barHeight: 3,     
   thumbRadius: 8,
   thumbGlowRadius: 16,
   timeLabelLocation: TimeLabelLocation.sides,
);
@suragch
Copy link
Owner

suragch commented Jul 20, 2021

That's a good point. It's too close. After observing another progress bar, I noticed that the left side of the thumb should only go to the left extent of the bar, and that the right side of the thumb should only go to the right side of the bar. Currently the center of the thumb goes to the left and the right. That makes it stick out too far (and be too close to the text.) Let me keep the text to the bar padding approximately the same for now but just fix the thumb location on the track.

@suragch
Copy link
Owner

suragch commented Jul 20, 2021

I've published a new release where the thumb radius does not extend beyond the left or right of the progress bar extent. I used a hard-coded 10 pixel padding for TimeLabelLocation.sides. Let me know if this works for you.

Screen Shot 2021-07-20 at 14 03 17

@ghost
Copy link
Author

ghost commented Jul 20, 2021

Great job! This is what I was looking for. It looks much better now. Thank you.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant