Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

invalid chars allowed in scanner name #28

Open
scrissti opened this issue Sep 5, 2022 · 2 comments
Open

invalid chars allowed in scanner name #28

scrissti opened this issue Sep 5, 2022 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers prioritize Issues to prioritise

Comments

@scrissti
Copy link

scrissti commented Sep 5, 2022

If scanner name contains space character it will fail execution:
image

@gsilvapt
Copy link
Contributor

I'd say this is kind of expected, considering this is a regular shell command being called in the terminal: python manage.py run_scanner <scanner_name> <extra_args>. Furthermore, if extra_args contain spaces it might break the scanner argument list too.

What we could do to ensure this does not happen is to create a field validator for scanner names and not allow whitespace characters!?

@fopina
Copy link
Contributor

fopina commented Oct 13, 2022

Field validator would make sense indeed.

Also, on mobile right now and can't get the link, but it has been mentioned that dkron async commands could be reworked to not rely on shell parsing (as many issues come out of it).

One quick solution in this case, as dkron allows spaces, could be to properly quote/escape the parameters in the shell

@gsilvapt gsilvapt added enhancement New feature or request good first issue Good for newcomers labels Jan 8, 2023
@gsilvapt gsilvapt added the prioritize Issues to prioritise label Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers prioritize Issues to prioritise
Projects
None yet
Development

No branches or pull requests

3 participants