Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix rule merging without a match #168

Merged
merged 1 commit into from
Dec 16, 2020

Conversation

bebraw
Copy link
Member

@bebraw bebraw commented Dec 16, 2020

@just-jeb, Do you think there are other cases to cover or would this do? The fix was quite simple.

Closes #167.

@just-jeb
Copy link
Contributor

@bebraw I'm not sure this is valid only for merge. What if options was array and I'd want to prepend it if there is a full match?
I'd still expect the entries in use to be appended and the options prepended when there is a match in loader.

@bebraw
Copy link
Member Author

bebraw commented Dec 16, 2020

I'm not sure this is valid only for merge. What if options was array and I'd want to prepend it if there is a full match?
I'd still expect the entries in use to be appended and the options prepended when there is a match in loader.

Can you open another issue about that and what it should look like? As mentioned earlier, it might need another operator to avoid implicit behavior.

I think I'll merge and publish this one as it's a valid fix and that's a feature.

@bebraw bebraw merged commit 7e8bd56 into develop Dec 16, 2020
@just-jeb
Copy link
Contributor

Thanks! Well, for my specific use case this fix is enough. I was just thinking about additional use cases that people might face.

@bebraw
Copy link
Member Author

bebraw commented Dec 16, 2020

@just-jeb Sure, if you have time and you want, feel free to send examples as that helps a lot in thinking about these. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mergeWithRules and shortcuts (loaders and use)
2 participants