Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Future - Change default behavior of merge #66

Closed
bebraw opened this issue Jan 31, 2017 · 1 comment · Fixed by #135
Closed

Future - Change default behavior of merge #66

bebraw opened this issue Jan 31, 2017 · 1 comment · Fixed by #135
Milestone

Comments

@bebraw
Copy link
Member

bebraw commented Jan 31, 2017

To quote @sapegin, a better merge default might be to "not add duplicates but also do not remove existing items."

Something along:

const merge = mergeBase({
    customizeArray: (a, b) => a.concat(differenceWith(b, a, isEqual)),
});
@bebraw bebraw changed the title 3.0 - Change default behavior of merge 4.0 - Change default behavior of merge Feb 19, 2017
@bebraw bebraw changed the title 4.0 - Change default behavior of merge 5.0 - Change default behavior of merge Mar 6, 2017
@bebraw bebraw changed the title 5.0 - Change default behavior of merge Future - Change default behavior of merge Mar 6, 2017
@bebraw bebraw added this to the v5 milestone Jul 3, 2020
@bebraw
Copy link
Member Author

bebraw commented Jul 3, 2020

It likely doesn't make sense to change this as the basic primitives in #135 feel strong enough. In particular unique solves the problem of duplicates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant