Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All Weather Data and some problems and Improvement ! #22

Open
aryadegari opened this issue May 4, 2015 · 2 comments
Open

All Weather Data and some problems and Improvement ! #22

aryadegari opened this issue May 4, 2015 · 2 comments
Assignees
Milestone

Comments

@aryadegari
Copy link

There is no method for fetching all weather data in just one query!
I wonder the timezone offset wasn't in data objects ! ("local_tz_offset" in WU conditions data)
astronomy data is integrated to location that may cause ambiguity, because it must have it's own method for requesting data.
there is no comfortable way to change URLs and their formats (ex: change url to cache server)
I think for Wunderground json in hourly data "condition" field misspelled ! (was "conditions" and must be "condition")
maybe it's very better to cache data with local database or just with Gson in preferences.
Thanks !

@survivingwithandroid
Copy link
Owner

Thx for your support. Your information are very interesting.
I was wondering "I think for Wunderground json in hourly data "condition" field misspelled ! (was "conditions" and must be "condition")" what means

@aryadegari
Copy link
Author

here :
https://github.com/survivingwithandroid/WeatherLib/blob/master/lib/src/main/java/com/survivingwithandroid/weather/lib/provider/wunderground/WeatherUndergroundProvider.java
line 295 : hourForecast.weather.currentCondition.setDescr(jHour.getString("conditions"));
must be hourForecast.weather.currentCondition.setDescr(jHour.getString("condition"));
please check other keys in json responses from providers.

@survivingwithandroid survivingwithandroid self-assigned this May 18, 2015
@survivingwithandroid survivingwithandroid added this to the 1.6.1 milestone May 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants