Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom files should keep their permissions #272

Closed
e-minguez opened this issue Mar 6, 2024 · 3 comments · Fixed by #305
Closed

Custom files should keep their permissions #272

e-minguez opened this issue Mar 6, 2024 · 3 comments · Fixed by #305
Assignees
Labels
bug Something isn't working triaged The team has reviewed the issue
Milestone

Comments

@e-minguez
Copy link
Contributor

For some use cases, the users would like to add executable files or scripts via combustion. In order to do so, the custom/files folder is being used.
However, even if the files/scripts are there with an executable flag, EIB seems to remove it here https://github.com/suse-edge/edge-image-builder/blob/main/pkg/combustion/custom.go#L44C61-L44C86

The workaround is to add a script that does the chmod a+x or whatever is needed but it would be nice if it keeps the permissions as the original ones.

@atanasdinov
Copy link
Contributor

Files are copied as non-executable whereas scripts are copied as executables. Doesn't this account for the requirements?

@e-minguez
Copy link
Contributor Author

Unfortunately no. Why does it need to change the original permissions? :) I want to be able to add an executable to my final system and in order to do it the only way right now is to drop it into the custom/files folder AND have a script on the custom/scripts that does a chmod...

@atanasdinov
Copy link
Contributor

Understood! We'll look into it.

@jdob jdob added bug Something isn't working triaged The team has reviewed the issue labels Mar 8, 2024
@jdob jdob added this to the 1.0.0 milestone Mar 8, 2024
@jdob jdob changed the title [RFE] When adding custom files, EIB should keep the permissions When adding custom files, EIB should keep the permissions Mar 8, 2024
@atanasdinov atanasdinov changed the title When adding custom files, EIB should keep the permissions Custom files should keep their permissions Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triaged The team has reviewed the issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants