Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Definition file argument to EIB is incorrect #283

Closed
jdob opened this issue Mar 8, 2024 · 0 comments · Fixed by #286
Closed

Definition file argument to EIB is incorrect #283

jdob opened this issue Mar 8, 2024 · 0 comments · Fixed by #286
Assignees
@jdob
Labels
bug Something isn't working triaged The team has reviewed the issue
Milestone
v1.0.0

Comments

@jdob
Copy link
Contributor

jdob commented Mar 8, 2024

In all of the renaming from "image configuration file" to "image definition file", the one place that was missed is the name of the actual CLI argument itself. Since this is part of the API, it's potentially misleading and certainly not something we want to ship 1.0 with. This issue is to rename that to --definition-file.
@jdob jdob self-assigned this Mar 8, 2024
@jdob jdob added bug Something isn't working triaged The team has reviewed the issue labels Mar 8, 2024
@jdob jdob added this to the 1.0.0 milestone Mar 8, 2024
@jdob jdob mentioned this issue Mar 8, 2024
Merged
@jdob jdob closed this as completed in #286 Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jdob jdob

Labels
bug Something isn't working triaged The team has reviewed the issue
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging a pull request may close this issue.

renamed '--config-file' to '--definition-file' jdob/edge-image-builder
1 participant
@jdob