PackageHub inclusion in RPM resolution silently errors on SLE Micro 6.0

[jdob]

Here's the specific line in question (https://github.com/suse-edge/edge-image-builder/blob/main/pkg/rpm/resolver/templates/rpm-resolution.sh.tpl):

SLE_SP=$(cat /etc/rpm/macros.sle | awk '/sle/ {print $2};' | cut -c4) && suseconnect -p PackageHub/15.$SLE_SP/{{ .Arch }}

In EIB 1.0.z/SLE Micro 5.5, this is arguably dangerous. It automatically adds PackageHub regardless, which could potentially be misleading to users by allowing them to install packages from that repo even though they aren't officially supported. This is addressed in the SUSE Edge 3.0 documentation and we don't need to backport, or otherwise address, this inside of EIB itself.

SLE Micro 6.0 doesn't even have a PackageHub repository, so this line fails. It doesn't fail the entire resolution process, but if someone looked at the logs they'll see something similar to the following:

Announcing system to https://scc.suse.com/ ...

Activating SL-Micro 6.0 x86_64 ...
-> Adding service to system ...

Successfully registered system
cat: /etc/rpm/macros.sle: No such file or directory

The fix for EIB 1.1 will simply be to remove this line. In the future, there are a few options for reintroducing something similar:

• As there is no PackageHub, we probably won't have a simple enablePackageHub flag, but we'll see how 6.0 evolves.
• There is an "Extras" repository currently, which lends itself to the idea that we may want to eventually add to the definition a list of SUSE channels to enable.

Until we know more and have an actual need, there are no plans to re-add this functionality.