new subtitle text colors #96
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh thanks man |
|
Can we add an option for custom colors? |
I can try, but the problem is that the css for the colors is generated when building. So it wouldn't be simple. |
Added 😘 |
ztpn
requested changes
Sep 17, 2024
| @@ -214,7 +214,7 @@ export function CaptionSetting(props: { | |||
| ); | |||
| } | |||
|
|
|||
| export const colors = ["#ffffff", "#b0b0b0", "#80b1fa", "#e2e535"]; | |||
| export const colors = ["#ffffff", "#80b1fa", "#e2e535", "#10B239FF"]; | |||
| const setOverrideCasing = useSubtitleStore((s) => s.setOverrideCasing); | ||
| const setDelay = useSubtitleStore((s) => s.setDelay); | ||
| const updateStyling = useSubtitleStore((s) => s.updateStyling); | ||
| const subtitleStore = useSubtitleStore(); |
There was a problem hiding this comment.
I think there was a reason we didn't do this earlier and called the function every time
| /> | ||
| ))} | ||
| {/* Add Color Picker */} |
There was a problem hiding this comment.
Instead of using the default browser color picker we should use a lib like react-colorful or something
| } | ||
| color={v} | ||
| active={props.styling.color === v} | ||
| key={v} | ||
| /> | ||
| ))} | ||
| {/* Add Color Picker */} |
There was a problem hiding this comment.
It's better to make the color picker a component that can be used anywhere
|
Also the custom color button looks ugly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request resolves #93
Added custom color picker for caption color
.pasithea(we require this for the contributor role)