Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config.Validate error but quiet #240

Closed
watarukura opened this issue Nov 29, 2023 · 4 comments · Fixed by #241
Closed

config.Validate error but quiet #240

watarukura opened this issue Nov 29, 2023 · 4 comments · Fixed by #241
Labels
bug Something isn't working
Milestone

Comments

@watarukura
Copy link

My .ghalint.yml was here.

---
excludes:
  - policy_name: action_ref_should_be_full_length_commit_sha
    workflow_file_path: .github/workflows/linters.yml
    job_name: markdownlint
bash-5.2$ ghalint run
bash-5.2$ echo $?
1

No error message, but exit 1.

---
excludes:
  - policy_name: action_ref_should_be_full_length_commit_sha
    action_name: torana-us/torana-shared-actions/.github/workflows/wc-markdownlint.yml

action_ref_should_be_full_length_commit_sha policy need action_name, so I rewrite.
https://github.com/suzuki-shunsuke/ghalint/blob/main/pkg/config/config.go#L49-L51

I want to display error message.

@suzuki-shunsuke suzuki-shunsuke added the bug Something isn't working label Nov 29, 2023
@suzuki-shunsuke
Copy link
Owner

Thank you for your report!
I'll take a look.

@suzuki-shunsuke
Copy link
Owner

@watarukura
Copy link
Author

Great job!
Thans!!

@suzuki-shunsuke
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants