Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Allow exclude deny_inherit_secrets #463

Closed
ponkio-o opened this issue Jun 6, 2024 · 4 comments · Fixed by #464
Closed

Feature Request: Allow exclude deny_inherit_secrets #463

ponkio-o opened this issue Jun 6, 2024 · 4 comments · Fixed by #464
Labels
enhancement New feature or request
Milestone

Comments

@ponkio-o
Copy link

ponkio-o commented Jun 6, 2024

Hi, @suzuki-shunsuke
Thank you for developing a great tool.

If you want to use Environment Secrets in Reusable workflows,you must pass the secret with secrets: inherit.

https://docs.github.com/en/actions/using-workflows/reusing-workflows#using-inputs-and-secrets-in-a-reusable-workflow

So I'd like to be able to exlude deny_inherit_secrets in the configuration file as well.

ref. https://x.com/ponkio_o/status/1798593685728514465 (JP)

@suzuki-shunsuke
Copy link
Owner

Thank you for your proposal!

@suzuki-shunsuke suzuki-shunsuke added the enhancement New feature or request label Jun 6, 2024
@suzuki-shunsuke suzuki-shunsuke added this to the v0.2.10 milestone Jun 6, 2024
@suzuki-shunsuke
Copy link
Owner

v0.2.10 is out 🎉
https://github.com/suzuki-shunsuke/ghalint/releases/tag/v0.2.10

@ponkio-o
Copy link
Author

ponkio-o commented Jun 6, 2024

Thank you for fixing quickly!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants