Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Poison fmt writer on error #37

Closed
KodrAus opened this issue May 6, 2019 · 0 comments · Fixed by #38
Closed

Poison fmt writer on error #37

KodrAus opened this issue May 6, 2019 · 0 comments · Fixed by #38

Comments

@KodrAus
Copy link
Collaborator

KodrAus commented May 6, 2019 •
edited
Loading

Since we can’t recover and retry formatting in case a formatter fails, we should poison the Stream in fmt::to_debug so that it always returns an error if it encounters one while formatting.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Poison the debug writer on error sval-rs/sval
1 participant
@KodrAus