Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cloning OwnedValue::from<String> is not cheap #65

Closed
KodrAus opened this issue Aug 26, 2019 · 0 comments · Fixed by #72
Closed

Cloning OwnedValue::from<String> is not cheap #65

KodrAus opened this issue Aug 26, 2019 · 0 comments · Fixed by #72

Comments

@KodrAus
Copy link
Collaborator

KodrAus commented Aug 26, 2019

When creating an OwnedValue from a String we store it as a Token(String), so each clone would then mean cloning the inner String value. We should store something like Arc<str> instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ensure cloning a string in OwnedValue is cheap sval-rs/sval
1 participant
@KodrAus