Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CINDER data support for different group structures #16

Open
gonuke opened this issue May 11, 2017 · 1 comment
Open

Update CINDER data support for different group structures #16

gonuke opened this issue May 11, 2017 · 1 comment

Comments

@gonuke
Copy link
Member

gonuke commented May 11, 2017

A user has contributed some comments about code changes to allow 175-group CINDER support

@gonuke
Copy link
Member Author

gonuke commented May 11, 2017

From Hesham Khater (LLNL):

I edited the FEINDLib.C and Consts.h files and changed the number of groups from 63 to 175. But now I get a different error regarding the format. Sorry I am an old fossil who can only handle fortran!

I am attaching the new library and hopefully a simple change is needed.

I also had to get help from a colleague to get alara to recompile. The new compiler had trouble with the 15 years old code and she added few lines to get it to work. I am listing the changes below.

Changes needed:

Several places had use of C functions without declaring them. Used to be
able
to get away from it, but not now.



Had to add to alara.h:

#include <string.h>

to get strcmp declared.


Several messsages about atoi & atof not declared.
Had to add include file stdlib.h for these.

Files changed for this reason are in:

src/DataLib/FEINDLib/FEIND

Original files were saved.

Cinder.cpp
DecayEndf6.cpp
Eaf41.cpp
EndfIeaf.cpp


if g++ -DHAVE_CONFIG_H -I. -I. -I../.. -I../../src -g -O2 -MT input.o
-MD -MP -MF ".deps/input.Tpo" -c -o input.o input.C;
then mv -f ".deps/input.Tpo" ".deps/input.Po"; else rm -f
".deps/input.Tpo"; exit 1; fi
input.C: In function 'int tokenType(char*)':
input.C:80: error: invalid conversion from 'const char*' to 'char*'
<---- Problem
input.C: In function 'const char* searchNonXSPath(const char*)':
input.C:122: warning: deprecated conversion from string constant to 'char*'
input.C: In function 'const char* searchXSPath(const char*)':
input.C:134: warning: deprecated conversion from string constant to 'char*'
input.C: In function 'const char* searchPath(const char*, const char*,
const char*)':
input.C:148: warning: deprecated conversion from string constant to 'char*'
input.C:170: warning: deprecated conversion from string constant to 'char*'
input.C:182: warning: deprecated conversion from string constant to 'char*'
input.C:191: warning: deprecated conversion from string constant to 'char*'
gmake[4]: *** [input.o] Error 1
gmake[4]: Leaving directory /g/g11/chase3/khater/alara-2.8.1/src/Util' gmake[3]: *** [all] Error 2 gmake[3]: Leaving directory /g/g11/chase3/khater/alara-2.8.1/src/Util'
gmake[2]: *** [all-recursive] Error 1
gmake[2]: Leaving directory /g/g11/chase3/khater/alara-2.8.1/src' gmake[1]: *** [all-recursive] Error 1 gmake[1]: Leaving directory /g/g11/chase3/khater/alara-2.8.1'
gmake: *** [all] Error 2

cd src/Util

input.C has on line 80:

char *tokenType = strstr(tokenList,token);

have to change to:

const char *tokenType = strstr(tokenList,token);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant