Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernization of ALARA build #41

Open
gonuke opened this issue May 31, 2024 · 2 comments
Open

Modernization of ALARA build #41

gonuke opened this issue May 31, 2024 · 2 comments
Assignees

Comments

@gonuke
Copy link
Member

gonuke commented May 31, 2024

ALARA needs to have its build system and some language features udpated.

  1. Newer CMake version
  2. c++-17 standards don't allow dynamic exceptions - maybe other things?
@ahnaf-tahmid-chowdhury ahnaf-tahmid-chowdhury self-assigned this Jun 1, 2024
@MicahGale
Copy link

Is there a specific version of CMake and c++ that this should be targeting?

@ahnaf-tahmid-chowdhury
Copy link
Member

CMake 3.18 is recommended as it enables setting the minimum version of different packages. I'm not sure why we need to upgrade to C++17, but in such a case, we can replace dynamic exceptions (throw without an explicit exception specification) with appropriate error handling mechanisms such as std::exception and try-catch blocks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants