-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow failures of builds using MOAB master
and develop
branches.
#847
Labels
Comments
I don't have any specific need for Docker images with develop or master versions of MOAB. |
I think we are ready to close the issue since it has been solved by PR #899 |
I agree that this is no longer relevant and can be closed. I'll let @pshriwise confirm.... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As I recall, these builds are present to notify us of any changes upstream in MOAB that might break DAGMC builds/tests.
We currently require these to pass in CI, which I think is a little overkill. IMO it's sufficient to require that our builds/tests pass and Docker images publish successfully only for official releases of MOAB. I'm curious if @shimwell may have a need for Docker images using MOAB's
develop
andmaster
branches?It's still very useful to have these builds of course, so I'm going to look into allowing failures for these builds but always running them for merges into our
develop
branch.The text was updated successfully, but these errors were encountered: