localize git submodule stuff to only when BUILD_UWUW #968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nuclearkevin
approved these changes
Dec 3, 2024
There was a problem hiding this comment.
Thanks @gonuke! I've tested these changes in Cardinal and can confirm that it solves the CIVET issue.
pshriwise
approved these changes
Dec 4, 2024
|
I'm working on the Win failures here: #966 |
|
I rebased this on |
pshriwise
approved these changes
Dec 12, 2024
We decided to "pause" Windows CI, perhaps with plans to deprecate. It was only ever a priority to support the Cubit plugin, which is no longer a priority. |
Ah, thanks for clarifying! I wasn't following that closely. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #967
Changes
Localize the invocation of
git submodulesto occur only whenBUILD_UWUWis true.