Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enrich implementation methods #37

Open
FusionSandwich opened this issue Aug 8, 2024 · 0 comments · May be fixed by #38
Open

Enrich implementation methods #37

FusionSandwich opened this issue Aug 8, 2024 · 0 comments · May be fixed by #38

Comments

@FusionSandwich
Copy link
Contributor

Currently, I don't know how others want the function enrich() to be implemented. I think that the extra testing requirements to have enrich() able to be called with mix_by_volume(), make_mat_from_atom(), and make_mat() is worth it. Since users will still need to specify the material, atom, and isotopes to be enriched. That should provide adequate context for users to not be confused with their enrichments, while still providing a large amount of flexibility.

@FusionSandwich FusionSandwich linked a pull request Aug 8, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant