Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename lucia adder to auth #247

Closed
benmccann opened this issue Oct 28, 2024 · 13 comments · Fixed by #299
Closed

Rename lucia adder to auth #247

benmccann opened this issue Oct 28, 2024 · 13 comments · Fixed by #299

Comments

@benmccann
Copy link
Member

Folks are getting really confused and thinking it's using a deprecated library

@Rich-Harris
Copy link
Member

It does feel a bit 'one true auth solution' if we do that, and I'm not sure that it is — I can't log in with google or github or biometrics or a passkey or whatever, there's no bot detection or email verification or password resets or the many other things that go into authentication, and we don't have anything to say about authorization. And it's tied to one specific ORM.

I'm not saying lucia is a name that we should keep, but I'm a little wary of people's expectations around auth. I can imagine Laravel developers saying 'aww, that's cute'.

@manuel3108
Copy link
Member

Maybe basic-auth or something

@benmccann
Copy link
Member Author

I think we can add those things over time. We need to start somewhere

basic-auth feels weird to me because then as we add features, at what point do we remove basic- from the name?

@Conduitry
Copy link
Member

'Basic auth' very much has an existing precise meaning already, which I really don't think we should try to go against.

@AdrianGonz97
Copy link
Member

How about lucia-guide or lucia-v4? We could also add lucia as an alias so that people can still write npx sv add lucia

@benmccann
Copy link
Member Author

yeah, someone had suggested lucia-guide on discord - though someone else then responded that it sounds like you're setting up documentation or something along those lines

I kind of want to send a PR for a feature that's not in the Lucia guide just so we can stop calling it anything related to Lucia 😆

@AdrianGonz97
Copy link
Member

lucia-inspired then?

gives us leeway to change things in the future while also referencing where it loosely came from

@benmccann
Copy link
Member Author

sounds fine to me

@Rich-Harris
Copy link
Member

email-password-auth? It's not like Lucia is doing anything particularly unusual

@Rich-Harris
Copy link
Member

(or maybe not that exact thing but you get the idea — something that says what it does)

@AdrianGonz97
Copy link
Member

AdrianGonz97 commented Oct 29, 2024

i think at that point we may as well just call it auth so that it can prompt a multiselect for the different auth methods like: email-password, oauth, passkey, etc

┌  Welcome to the Svelte CLI! (v0.5.11)
│
◇  What would you like to add to your project?
│  auth
│
◆  Which auth methods would you like to include?
│  ◻ email-password
│  ◻ oauth
│  ◻ passkey
│  ...
└

And it's tied to one specific ORM.

i think we can make an attempt at making it a bit more generic

@AdrianGonz97
Copy link
Member

also, yes, it would look a bit silly for the time being since there would only be a single auth method available:

┌  Welcome to the Svelte CLI! (v0.5.11)
│
◇  What would you like to add to your project?
│  auth
│
◆  Which auth methods would you like to include?
│  ◻ email-password
└

@MonsalvoGeoffrey
Copy link

image
Since each adder has text that is normally used to link to the library's documentation, I feel like this text is a better place to solve this problem that the title

Having it titled auth and the text beside it reading Following lucia's guideline (https://lucia-auth.com) would make it perfectly clear
Sure, every other add-on only have a link, but I don't think it HAVE to be consitent, if lucia's an edge case, then it get the treatment of an edge case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants