Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(reroute): Allow for dynamic asynchronously rerouting #13176

Closed
nikosgram opened this issue Dec 16, 2024 · 1 comment · Fixed by #13520 · May be fixed by #13422
Closed

feat(reroute): Allow for dynamic asynchronously rerouting #13176

nikosgram opened this issue Dec 16, 2024 · 1 comment · Fixed by #13520 · May be fixed by #13422
Labels
feature / enhancement New feature or request

Comments

@nikosgram
Copy link

Describe the problem

The current SvelteKit Reroute functionality doesn't support dynamic rerouting for localization where settings are stored in a database. We need to implement a multi-domain, multi-prefix localization system that allows flexible domain/language combinations.

Example configuration:

  • Domains: example.com, example.uk, example.gr, example.fr
  • Localizations: en-gb, el-gr, en-gr, fr-fr, en-fr

Domain/prefix mappings:

el-gr:
- example.com/el-gr/
- example.gr/

en-gr:
- example.com/en-gr/
- example.gr/en/

en-gb:
- example.com/
- example.uk/

Describe the proposed solution

Modify the Reroute function to return MaybePromise<void | string> and update its implementation in server/response.js and client/client.js.

A proof-of-concept implementation: nikosgram@70d808e

I would appreciate feedback on this approach to ensure I'm not overlooking any potential issues or better alternatives.

Alternatives considered

No response

Importance

i cannot use SvelteKit without it

Additional Information

No response
@nikosgram
Copy link
Author

nikosgram commented Dec 16, 2024 •
edited
Loading

An example of how this could work:

import type { Reroute } from '@sveltejs/kit';

export const reroute: Reroute = async ({ url }) => {
    if (url.pathname.startsWith('/api')) {
        return;
    }
    
    const response = await fetch(url.protocol + '//' + url.host + '/api/locales');

    const locales = await response.json(); // as Type[];

    // write re-routing logic here
};

@eltigerchino eltigerchino added the feature / enhancement New feature or request label Dec 17, 2024
@nikosgram nikosgram mentioned this issue Dec 17, 2024
Closed
6 tasks
@eltigerchino eltigerchino linked a pull request Dec 18, 2024 that will close this issue
feat: Allow for dynamic asynchronously rerouting #13186
Closed
6 tasks
dummdidumm added a commit that referenced this issue Feb 5, 2025
@dummdidumm
feat: add server reroute hook
6071077 
closes #13176
@dummdidumm dummdidumm mentioned this issue Feb 5, 2025
Draft
5 tasks
dummdidumm added a commit that referenced this issue Feb 28, 2025
@dummdidumm
feat: allow async reroute
858aa8f 
closes #13176
@dummdidumm dummdidumm mentioned this issue Feb 28, 2025
Merged
5 tasks
dummdidumm added a commit that referenced this issue Mar 4, 2025
@dummdidumm
feat: allow async reroute (#13520)
993fa25 
closes #13176
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature / enhancement New feature or request
Projects
None yet
Milestone
No milestone
2 participants
@nikosgram @eltigerchino