Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs appear to not be deploying correctly when PRs are merged #1600

Closed
rmunn opened this issue May 30, 2021 · 0 comments · Fixed by #1607
Closed

Docs appear to not be deploying correctly when PRs are merged #1600

rmunn opened this issue May 30, 2021 · 0 comments · Fixed by #1607
Labels
documentation Improvements or additions to documentation

Comments

@rmunn
Copy link
Contributor

rmunn commented May 30, 2021

Describe the bug

#1566 was merged about 14 hours ago (4:17 PM CDT on 2021-05-29), and the Deploy docs action appears to have run successfully after that PR was merged. But the docs change made in PR #1566 (renaming one parameter of the handle hook from render to resolve) has not made it to https://kit.svelte.dev/docs: as of ten minutes ago (6:07 AM CDT on 2021-05-30) I was still seeing render as the parameter name when I load the page. I made sure to open the Network tab of the dev console and disable the browser cache, and I watched the HTML response come back from the server with render still showing as the parameter of the handle hook.

image

Logs

Headers of the HTML response I received:

HTTP/3 200 OK
date: Sun, 30 May 2021 11:07:32 GMT
content-type: text/html
cache-control: public, max-age=60
permissions-policy: interest-cohort=()
age: 2
vary: Accept-Encoding
x-nf-request-id: e584e4f1-b723-4b1d-974c-db8d8d02f131
cf-cache-status: DYNAMIC
cf-request-id: 0a5e8e31b20000f8ebdda0c000000001
expect-ct: max-age=604800, report-uri="https://report-uri.cloudflare.com/cdn-cgi/beacon/expect-ct"
report-to: {"endpoints":[{"url":"https:\/\/a.nel.cloudflare.com\/report\/v2?s=SHlDfn6e2Sl%2FWjBf28MJMmL8eix7y3dD4IEH0l7MOvGhuUPOscwWXLd8aqP9%2Ffs6vDALrbaYiRKfREzwg1FXy8519zSypqLqfgZp73GayFvpjtqOyEJKq0aPJL8%3D"}],"group":"cf-nel","max_age":604800}
nel: {"report_to":"cf-nel","max_age":604800}
server: cloudflare
cf-ray: 65777fc918c4f8eb-NRT
content-encoding: br
alt-svc: h3-27=":443"; ma=86400, h3-28=":443"; ma=86400, h3-29=":443"; ma=86400

(Rest of the bug report template omitted because this isn't a Svelte-Kit bug per se, so much of the info requested is irrelevant here).

Severity

Not severe at all to me, as I've been watching the repo and know that the parameter was renamed. But someone who starts a new Svelte-Kit project and tries to use the handle hook might be very confused until the docs update with the change that should have been deployed yesterday.

Additional context

It's possible that there's something peculiar in my network setup that's serving me a stale page despite my best efforts to avoid it; if everyone else is seeing the fresh version of the page and it's just me, then this issue is safe to close.

@benmccann benmccann added the documentation Improvements or additions to documentation label May 30, 2021
@pngwn pngwn mentioned this issue May 31, 2021
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants