-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
$service-worker files exclusion improvements. Make it automatic and Configurable. #1636
Comments
Based off the discussion in sveltejs/sapper#1095 I'm guessing that we might not want to ignore hidden files by default. But it sounds reasonable to provide an option that lets you filter which files are included / ignored |
@benmccann Thanks for pointing me to the sapper issue. I searched for a similar issue in Sveltekit but couldn't find it there. I didn't think about looking into sapper issues. I have done the changes not sure if I am in the right direction. |
This is now configurable through the serviceWorker option, thanks for the PR! |
Hello, just a little improvement request : on my Mac it's |
Is your feature request related to a problem? Please describe.
.gitkeep
file available inassets/some-dir
is available in$service-worker.files
causing this file to be requested unnecessarily(and surprisingly).Describe the solution you'd like
Here I see that only one file
.DS_STORE
is excluded from$service-worker.files
. I would suggest the followingDescribe alternatives you've considered
For the time being, I have excluded
.gitkeep
in service-worker.ts which works for me but increases service-worker.js file size unnecessarily.How important is this feature to you?
This is not super important. But I would love to contribute if you can provide the next step here.
Additional context
It shows a .gitkeep file being requested from service-worker
The text was updated successfully, but these errors were encountered: