Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't bail on a (static adapter) build after the first 404 #1935

Closed
happycollision opened this issue Jul 17, 2021 · 1 comment
Closed

Don't bail on a (static adapter) build after the first 404 #1935

happycollision opened this issue Jul 17, 2021 · 1 comment

Comments

@happycollision
Copy link
Contributor

happycollision commented Jul 17, 2021

Describe the problem

It's extremely tedious (especially when converting a Sapper app with lots of old, broken links) to

  1. Run a build (with the static adapter)
  2. See a single 404 error, which ends the build
  3. Fix that single error
  4. Repeat the above for all 37 404s.

Describe the proposed solution

It would be far better if the first encounter with a 404 didn't immediately bail on the rest of the adapter phase of the build. Sapper used to give a full list of all files, including links that 404'ed. It would be nice if SvelteKit either did the same, or at least produced a full list of 404s instead of showing you one error for each build attempt.

Alternatives considered

I mean, yeah. I can just run the build one time for every single error as described above, but that takes an order of magnitude more time/compute and attention. It's nuts.

The other alternative is to stay on Sapper.

Importance

would make my life easier

Additional Information

...failure number 23...

CleanShot 2021-07-17 at 14 20 14@2x

...fix the code for 5 seconds...
...run npm run build...
...81 seconds later...
...failure number 24...

CleanShot 2021-07-17 at 14 18 42@2x

...fix the code for 5 seconds...
...run npm run build...
...81 seconds later...
...failure number 25...

CleanShot 2021-07-17 at 14 24 35@2x

(you get the picture, and 81 seconds is accurate 😆)

@happycollision happycollision changed the title Don't bail on a build after first 404 Don't bail on a build after the first 404 Jul 17, 2021
@happycollision happycollision changed the title Don't bail on a build after the first 404 Don't bail on a (static adapter) build after the first 404 Jul 17, 2021
@happycollision
Copy link
Contributor Author

Ok. I found that prerender: {force: true} has the intended effect. I'll open another issue for the naming of that option, as I saw it before, but it didn't make sense that this would be what I wanted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant