Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSP support for AMP pages #3557

Closed
Tracked by #3499
Rich-Harris opened this issue Jan 26, 2022 · 1 comment
Closed
Tracked by #3499

CSP support for AMP pages #3557

Rich-Harris opened this issue Jan 26, 2022 · 1 comment
Labels
feature / enhancement New feature or request
Milestone
1.0

Comments

@Rich-Harris
Copy link
Member

Describe the problem

We added CSP support in #3499, but it didn't apply to AMP pages.

Describe the proposed solution

I think we just have to add this monstrosity but I didn't look too closely yet

Alternatives considered

No response

Importance

nice to have

Additional Information

No response
This was referenced Jan 26, 2022
Merged
Closed
@Rich-Harris Rich-Harris mentioned this issue Apr 25, 2022
Merged
13 tasks
@Rich-Harris Rich-Harris added the feature / enhancement New feature or request label Apr 25, 2022
@Rich-Harris Rich-Harris added this to the 1.0 milestone Apr 25, 2022
@Rich-Harris
Copy link
Member Author

This... isn't actually possible. If you follow the instructions in https://amp.dev/documentation/guides-and-tutorials/optimize-and-measure/secure-pages/, your page won't validate:

image

AMP is a trainwreck.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature / enhancement New feature or request
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
1 participant
@Rich-Harris