Merge pull request #1019 from sveltejs/gh-1012

deconflict computed properties with arguments to _recompute

Author: Rich-Harris

src/generators/Generator.ts

@@ -485,15 +485,18 @@ export default class Generator {
 					`);
 				};
 
-				const addDeclaration = (key: string, node: Node, disambiguator?: string) => {
+				const addDeclaration = (key: string, node: Node, disambiguator?: string, conflicts?: Record<string, boolean>) => {
 					const qualified = disambiguator ? `${disambiguator}-${key}` : key;
 
 					if (node.type === 'Identifier' && node.name === key) {
 						this.templateVars.set(qualified, key);
 						return;
 					}
 
-					let name = this.getUniqueName(key);
+					let deconflicted = key;
+					if (conflicts) while (deconflicted in conflicts) deconflicted += '_'
+
+					let name = this.getUniqueName(deconflicted);
 					this.templateVars.set(qualified, name);
 
 					// deindent
@@ -548,7 +551,11 @@ export default class Generator {
 						computations.push({ key, deps });
 
 						const prop = templateProperties.computed.value.properties.find((prop: Node) => getName(prop.key) === key);
-						addDeclaration(key, prop.value, 'computed');
+
+						addDeclaration(key, prop.value, 'computed', {
+							state: true,
+							changed: true
+						});
 					};
 
 					templateProperties.computed.value.properties.forEach((prop: Node) =>

test/runtime/samples/computed-values-deconflicted/_config.js

@@ -0,0 +1,10 @@
+export default {
+	html: '<span>waiting</span>',
+
+	test(assert, component, target) {
+		component.set({ x: 'ready' });
+		assert.htmlEqual(target.innerHTML, `
+			<span>ready</span>
+		`);
+	}
+};

test/runtime/samples/computed-values-deconflicted/main.html

@@ -0,0 +1,14 @@
+<span>{{state}}</span>
+
+<script>
+	export default {
+		data() {
+			return {
+				x: 'waiting'
+			};
+		},
+		computed: {
+			state: x => x
+		}
+	};
+</script>