-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: avoid relying on Node specifics within compiler #14314
Conversation
🦋 Changeset detectedLatest commit: 69ff33b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
preview: https://svelte-dev-git-preview-svelte-14314-svelte.vercel.app/ this is an automated message |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couldn't nullish coalescence be used here, like process?.cwd?.()??Deno?.cwd?.()??undefined
?
I know it looks a little ugly, but it could look nicer with some line breaks or spacing (not to mention that the nested ternaries arguably look a little worse)
No, that would throw if |
This will stop this error from happening, right? |
|
Would you say this is a commitment from the team? That is to say: not relying on node and runtime specifics for compilation? I've been working on a project that makes use of a custom implementation of ES in order to compile svelte strings, and this took me by surprise when I tried to upgrade from v4 to v5. |
fixes #14294