Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: account for global block in is_empty #14677

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Conversation

paoloricciuti
Copy link
Member

@paoloricciuti paoloricciuti commented Dec 11, 2024

Closes #14675

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Dec 11, 2024

🦋 Changeset detected

Latest commit: 6df3324

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

Playground

pnpm add https://pkg.pr.new/svelte@14677

Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is why I voted for the separate walk - it gets hairy to pass this through to everything. Anyway let's go with this.

@dummdidumm dummdidumm merged commit ea6fd95 into main Dec 11, 2024
11 checks passed
@dummdidumm dummdidumm deleted the global-root-empty branch December 11, 2024 21:10
@github-actions github-actions bot mentioned this pull request Dec 11, 2024
@paoloricciuti
Copy link
Member Author

this is why I voted for the separate walk - it gets hairy to pass this through to everything. Anyway let's go with this.

i think this should be it because we basically have to account for it when checking for is_used...i also thought of incorporating it in the is_used function but we do have to account for it in the keyframes rule too.

Let's see, if it's get's to complex we can refactor it to use walk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Selectors inside of :root inside of :global are ignored.
2 participants