Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only detach nodes if necessary #26

Closed
Rich-Harris opened this issue Nov 25, 2016 · 4 comments · May be fixed by leonardoadame/svelte#13
Closed

Only detach nodes if necessary #26

Rich-Harris opened this issue Nov 25, 2016 · 4 comments · May be fixed by leonardoadame/svelte#13

Comments

@Rich-Harris
Copy link
Member

Right now, Svelte detaches every child of every node during teardown. It only needs to detach the top-level ones.
@pillaiindu
Copy link

Is it fixed now?

@Rich-Harris
Copy link
Member Author

yes! It's been fixed for over a year

@pillaiindu
Copy link

The performance of Svelte for swapping rows in this benchmark was very slow. How would it behave now?

@Rich-Harris
Copy link
Member Author

The same. There's an issue for it: #588. It hasn't been a big priority because it's a fairly contrived example you don't often encounter in the wild

@btakita btakita mentioned this issue Mar 13, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Snyk] Upgrade dts-buddy from 0.1.14 to 0.2.3 leonardoadame/svelte
2 participants
@Rich-Harris @pillaiindu