Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Child combinators crash compiler on elements with spread attributes #5465

Closed
SourceR85 opened this issue Sep 29, 2020 · 1 comment · Fixed by #5467
Closed

Child combinators crash compiler on elements with spread attributes #5465

SourceR85 opened this issue Sep 29, 2020 · 1 comment · Fixed by #5467
Labels
bug

Comments

@SourceR85
Copy link

After the update to 3.28.0 this error breaks svelte:
Win Chrome 85.0.4183.121/node.js 14.11.0:
Cannot read property 'toLowerCase' of null
Firefox 81.0 (64-Bit) reports TypeError: attr.name is null

After some tests in repl I found the source of this crash:
The svelte parser dosn't like CSS-sibling selectors (+, ~) in combination with destructored variables...

REPL:
https://svelte.dev/repl/fe56269d373a462cb363a485ddc7aa09?version=3.28.0
@Conduitry Conduitry changed the title Error in 3.28.0 Child combinators crash compiler on elements with spread attributes Sep 29, 2020
@tanhauhau tanhauhau mentioned this issue Sep 29, 2020
Merged
4 tasks
@Conduitry
Copy link
Member

This has been fixed in 3.29.0 - https://svelte.dev/repl/fe56269d373a462cb363a485ddc7aa09?version=3.29.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix attribute name is undefined tanhauhau/svelte
2 participants
@SourceR85 @Conduitry