Skip to content
This repository has been archived by the owner on Feb 15, 2023. It is now read-only.

Would there be any advantage in upgrading to Rollup 2? #120

Closed
SteveALee opened this issue Mar 11, 2020 · 4 comments
Closed

Would there be any advantage in upgrading to Rollup 2? #120

SteveALee opened this issue Mar 11, 2020 · 4 comments

Comments

@SteveALee
Copy link

I see there are breaking changes but also apparently some goodies too.

@Conduitry
Copy link
Member

It'd probably be a good idea, because I imagine Rollup 1 isn't going to be maintained any longer. The main breaking change would probably be dropping support for Node 8, which is end-of-life so I don't see that as much of an issue.

@zqianem
Copy link

zqianem commented May 1, 2020

Specifically, Rollup 2 fixes watch issues like rollup/rollup#1666 via rollup/rollup#2988. While this doesn't seem to affect too many setups, having a working live-reload is important for first impressions, imo. Is there anything blocking #123 currently?

@frederikhors
Copy link
Contributor

The question is WHY NOT? IMO.

Anyway no problem at all, I'm already using it.

@Conduitry
Copy link
Member

Yeah we do want to update to Rollup 2 probably. I don't think losing Node 8 support is a show-stopper. Right now I'm waiting for rollup/plugins#304 to settle down though. A fix has been merged in, but not yet released.

@antony antony closed this as completed May 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants