Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use mtime as cache busting parameter #348

Closed
benmccann opened this issue May 29, 2022 · 0 comments · Fixed by #356
Closed

Use mtime as cache busting parameter #348

benmccann opened this issue May 29, 2022 · 0 comments · Fixed by #356
Labels
enhancement New feature or request triage Awaiting triage by a project member

Comments

@benmccann
Copy link
Member

benmccann commented May 29, 2022

Describe the problem

The config file is currently loaded with Date.now() as a cache-busting parameter. If mtime were instead used then SvelteKit could load the config with the same cache-busting parameter without us having to pass the config around which would simplify some APIs (see sveltejs/kit#5094).

Describe the proposed solution

Use mtime

Alternatives considered

  1. the user imports the config
  2. split the config file between svelte.config.js and vite.config.js
  3. plugin intercommunication (though I don't think this would actually work)
  4. await plugin creation function

Importance

would make my life easier

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request triage Awaiting triage by a project member
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant