perf: 移除不必要的 api

svga · Aug 18, 2021 · 3f4ef1a · 3f4ef1a
1 parent 010b19c
commit 3f4ef1a
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 17 deletions.
diff --git a/library/src/main/java/com/opensource/svgaplayer/utils/log/DefaultLogCat.kt b/library/src/main/java/com/opensource/svgaplayer/utils/log/DefaultLogCat.kt
@@ -22,15 +22,7 @@ class DefaultLogCat : ILogger {
         Log.w(tag, msg)
     }
 
-    override fun error(tag: String, msg: String) {
-        Log.e(tag, msg)
-    }
-
-    override fun error(tag: String, error: Throwable) {
-        Log.e(tag, "", error)
-    }
-
-    override fun error(tag: String, msg: String, error: Throwable) {
+    override fun error(tag: String, msg: String?, error: Throwable?) {
         Log.e(tag, msg, error)
     }
 }
diff --git a/library/src/main/java/com/opensource/svgaplayer/utils/log/ILogger.kt b/library/src/main/java/com/opensource/svgaplayer/utils/log/ILogger.kt
@@ -8,7 +8,5 @@ interface ILogger {
     fun info(tag: String, msg: String)
     fun debug(tag: String, msg: String)
     fun warn(tag: String, msg: String)
-    fun error(tag: String, msg: String)
-    fun error(tag: String, error: Throwable)
-    fun error(tag: String, msg: String, error: Throwable)
+    fun error(tag: String, msg: String?, error: Throwable?)
 }
diff --git a/library/src/main/java/com/opensource/svgaplayer/utils/log/LogUtils.kt b/library/src/main/java/com/opensource/svgaplayer/utils/log/LogUtils.kt
@@ -38,20 +38,20 @@ internal object LogUtils {
         if (!SVGALogger.isLogEnabled()) {
             return
         }
-        SVGALogger.getSVGALogger()?.error(tag, msg)
+        SVGALogger.getSVGALogger()?.error(tag, msg, null)
     }
 
-    fun error(tag: String = TAG, msg: String, error: Throwable) {
+    fun error(tag: String, error: Throwable) {
         if (!SVGALogger.isLogEnabled()) {
             return
         }
-        SVGALogger.getSVGALogger()?.error(tag, msg, error)
+        SVGALogger.getSVGALogger()?.error(tag, error.message, error)
     }
 
-    fun error(tag: String, error: Throwable) {
+    fun error(tag: String = TAG, msg: String, error: Throwable) {
         if (!SVGALogger.isLogEnabled()) {
             return
         }
-        SVGALogger.getSVGALogger()?.error(tag, error)
+        SVGALogger.getSVGALogger()?.error(tag, msg, error)
     }
 }