fix: Creating a cache file may cause a crash

svga · Nov 28, 2020 · e0dd50b · e0dd50b
1 parent f25b11a
commit e0dd50b
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/library/src/main/java/com/opensource/svgaplayer/SVGACache.kt b/library/src/main/java/com/opensource/svgaplayer/SVGACache.kt
@@ -23,7 +23,7 @@ object SVGACache {
         if (isInitialized()) return
         context ?: return
         cacheDir = "${context.cacheDir.absolutePath}/svga/"
-        File(cacheDir).takeIf { !it.exists() }?.mkdir()
+        File(cacheDir).takeIf { !it.exists() }?.mkdirs()
         this.type = type
     }
 

diff --git a/library/src/main/java/com/opensource/svgaplayer/SVGAParser.kt b/library/src/main/java/com/opensource/svgaplayer/SVGAParser.kt
@@ -4,6 +4,7 @@ import android.content.Context
 import android.net.http.HttpResponseCache
 import android.os.Handler
 import android.os.Looper
+import android.util.Log
 import com.opensource.svgaplayer.proto.MovieEntity
 import com.opensource.svgaplayer.utils.log.LogUtils
 import org.json.JSONObject
@@ -237,8 +238,13 @@ class SVGAParser(context: Context?) {
                 readAsBytes(inputStream)?.let { bytes ->
                     threadPoolExecutor.execute {
                         SVGACache.buildSvgaFile(cacheKey).let { cacheFile ->
-                            cacheFile.takeIf { !it.exists() }?.createNewFile()
-                            FileOutputStream(cacheFile).write(bytes)
+                            try {
+                                cacheFile.takeIf { !it.exists() }?.createNewFile()
+                                FileOutputStream(cacheFile).write(bytes)
+                            } catch (e: Exception) {
+                                LogUtils.error(TAG, "create cache file fail.", e)
+                                cacheFile.delete()
+                            }
                         }
                     }
                     LogUtils.info(TAG, "Input.inflate start")