Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhaul transaction model #3457

Closed
JobDoesburg opened this issue Oct 27, 2023 · 2 comments
Closed

Overhaul transaction model #3457

JobDoesburg opened this issue Oct 27, 2023 · 2 comments
Labels
app:payments Issues regarding the payments-app chore Something that is not a bug or a feature, does not change production behaviour priority: low Should be dealt with when nothing else remains. request-for-comments Author wants to have other people respond for their opinion

Comments

@JobDoesburg
Copy link
Contributor

What?

The current payment transaction model, especially for Thalia Pay payments, works nice, but is difficult and not really elegant.

TOSTI has a much more elegant transaction model, that is plug and play, computationally more efficient and easier to maintain (especially since TOSTI is also using it, so if we were to move this to a separate repository, maintenance is a 2-vliegen-in-1-klap thing).

We should consider refactoring the payments model, especially getting rid of payment batches for Thalia pay.

Why?

Higher code quality (more elegant), easier data minimization, higher data integrity insurance, computational efficiency (requesting the current balance doesn't require a SUM), a data model that is more similar to actual bookkeeping in MoneyBird

How?

A very big refactor

@JobDoesburg JobDoesburg added priority: low Should be dealt with when nothing else remains. app:payments Issues regarding the payments-app request-for-comments Author wants to have other people respond for their opinion chore Something that is not a bug or a feature, does not change production behaviour labels Oct 27, 2023
@T8902 T8902 assigned T8902, mark-boute and Noah-marc and unassigned mark-boute, T8902 and Noah-marc Nov 8, 2023
@DeD1rk
Copy link
Member

DeD1rk commented Nov 9, 2023

TOSTI's transactions aren't a drop-in replacement for our payements. Transactions (primarily tracking balance) are totally different for payments (primarily tracking whether something has been paid). So I don't think we gain enough (a nicer system for tracking TPay balance) for the very high complexity of refactoring it (and still maintaining most of the payments app, as transactions doesn't cover all of that functionality).

@DeD1rk DeD1rk closed this as not planned Won't fix, can't repro, duplicate, stale Nov 9, 2023
@JobDoesburg
Copy link
Contributor Author

I agree it isn't a drop-in replacement, but I do think it could help us a lot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:payments Issues regarding the payments-app chore Something that is not a bug or a feature, does not change production behaviour priority: low Should be dealt with when nothing else remains. request-for-comments Author wants to have other people respond for their opinion
Projects
None yet
Development

No branches or pull requests

5 participants