Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(go): return decoding errors #10429

Merged
merged 2 commits into from
Oct 15, 2020
Merged

Conversation

kevinawoo
Copy link
Contributor

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: 3.0.0 branch for changes related to OpenAPI spec 3.0. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

We're not returning a a.client.decodeing error which is helpful for callers to determine what's wrong with an API call.

kevinawoo added a commit to armory/spin that referenced this pull request Aug 17, 2020
kevinawoo added a commit to armory/spin that referenced this pull request Aug 18, 2020
This also removes "*malformed" test cases since 2.14.4 doesn't return parsing errors

swagger-api/swagger-codegen#10434 reports the issue.
hopefully swagger-api/swagger-codegen#10429 be merged will add that ability back in.
mergify bot pushed a commit to spinnaker/spin that referenced this pull request Aug 18, 2020
* chore(gateapi): update gateapi from 5c625da5 using swagger 2.4.14

* feat(contribution): add instructions on how to generate gateapi using 2.4.1

* refact(gateapi): swagger 2.4.14 query params are typed now

* tests(gateapi): gateapi generated code expects valid JSON and headers

This also removes "*malformed" test cases since 2.14.4 doesn't return parsing errors

swagger-api/swagger-codegen#10434 reports the issue.
hopefully swagger-api/swagger-codegen#10429 be merged will add that ability back in.

* refactor(imports): fixed import styling

* chore(gateapi): use swagger-cli 2.4.15
gsapkal pushed a commit to gsapkal/spin that referenced this pull request Sep 10, 2020
…#292)

* chore(gateapi): update gateapi from 5c625da5 using swagger 2.4.14

* feat(contribution): add instructions on how to generate gateapi using 2.4.1

* refact(gateapi): swagger 2.4.14 query params are typed now

* tests(gateapi): gateapi generated code expects valid JSON and headers

This also removes "*malformed" test cases since 2.14.4 doesn't return parsing errors

swagger-api/swagger-codegen#10434 reports the issue.
hopefully swagger-api/swagger-codegen#10429 be merged will add that ability back in.

* refactor(imports): fixed import styling

* chore(gateapi): use swagger-cli 2.4.15
@HugoMario
Copy link
Contributor

thanks @kevinawoo !!

@HugoMario HugoMario merged commit d448c55 into swagger-api:master Oct 15, 2020
@kevinawoo kevinawoo deleted the fix/go-decoding branch October 15, 2020 18:19
This was referenced Mar 11, 2021
This was referenced Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants